feat(huddle): add SenseVoice for CJK locales#1
Open
LauraGPT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds the complete SenseVoice path requested in the review of block#2520, so the reported Korean locale no longer selects a model that does not support Korean.
What changed
sensevoice.SttFamily::SenseVoiceand configures sherpa-onnx 1.13.4 withmodel.int8.onnx,language = "auto", and ITN enabled.multilingualfallback with explicit primary-language routing:zh,yue,ja,ko-> SenseVoiceenand unsupported locales -> the existing English defaultArtifact verification
sherpa-onnx-sense-voice-zh-en-ja-ko-yue-int8-2024-07-17.tar.bz2163002883bytes7d1efa2138a65b0b488df37f8b89e3d91a60676e416f515b952358d83dfd347emodel.int8.onnx,tokens.txtI ran the official packaged zh/en/ja/ko/yue samples on CPU with sherpa-onnx 1.13.4. All five decoded successfully; the 4.608 s Korean sample completed in 0.211 s and was detected as
<|ko|>.Validation
ko-KRselectedparakeet-v3;ar-SAalso selectedparakeet-v3.cargo test --manifest-path desktop/src-tauri/Cargo.toml huddle:: -- --nocapture: 102 passed, 0 failed.cargo clippy --manifest-path desktop/src-tauri/Cargo.toml -- -D warnings: passed.cargo fmt --manifest-path desktop/src-tauri/Cargo.toml --check: passed.git diff --check: passed.This PR targets the contributor branch directly so it can be merged into block#2520 without rebasing or cherry-picking.